feat(securitypolicy): add MergeType support for policy merging#7918
feat(securitypolicy): add MergeType support for policy merging#7918rajatvig wants to merge 28 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add MergeType field to SecurityPolicy to enable policy merging similar to BackendTrafficPolicy. This allows route-level policies to merge with parent Gateway/Listener policies rather than completely overriding them. Fixes envoyproxy#6734 Signed-off-by: Rajat Vig <rvig@etsy.com>
zhaohuabing
force-pushed
the
feat/security-policy-merge
branch
from
95821a7 to
c8b4bdc
Compare
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7918 +/- ##
==========================================
+ Coverage 73.55% 73.56% +0.01%
==========================================
Files 242 242
Lines 36949 37071 +122
==========================================
+ Hits 27178 27272 +94
- Misses 7851 7876 +25
- Partials 1920 1923 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
internal/gatewayapi/testdata/securitypolicy-with-merge.out.yaml
Outdated
Show resolved
Hide resolved
|
Hi @rajatvig , thanks for working on this! |
…namspaces Signed-off-by: Rajat Vig <rvig@etsy.com>
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
|
/retest |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zhaohuabing
left a comment
zhaohuabing
left a comment
There was a problem hiding this comment.
LGTM.
#7918 (comment) is tracked in #8088 and can be addressed later.
|
/retest |
|
@rajatvig |
…t fix Signed-off-by: Rajat Vig <rvig@etsy.com>
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
Just fixed the last bit I think. |
|
@kkk777-7 @zhaohuabing Does this look good now? Any other points I need to address? |
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
…y-merge Signed-off-by: Rajat Vig <rvig@etsy.com>
@rudrakhp From what I could gather looking at the code, it would mostly affect secrets when the parent policy refers to a secret that the merged policy tries looking up in the route's namespace. There is an issue #8094 tracking that. Would it be ok to resolve this as part of that issue? |
5 participants
Add MergeType field to SecurityPolicy to enable policy merging similar
to BackendTrafficPolicy. This allows route-level policies to merge with
parent Gateway/Listener policies rather than completely overriding them.
Fixes #6734